Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BMI085 scaling issue #21960

Merged
merged 1 commit into from Oct 18, 2022
Merged

Fix BMI085 scaling issue #21960

merged 1 commit into from Oct 18, 2022

Conversation

lgarciaos
Copy link
Contributor

@lgarciaos lgarciaos commented Oct 14, 2022

Original BMI088 has 24G range so scale has a 24.0 multiplier within read_fifo_accel. Added a class variable RANGE which is assigned the correct value when the sensor type is received (16.0 or 24.0) - at accel_init().

Original BMI088 has 24G range so it was hardcoded for *scale* within
read_fifo_accel. Added a class variable accel_range which is assigned
the correct value when the sensor type is received (16.0 or 24.0).
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've tweaked the commit message and variable name
we will include this in 4.3.1

@tridge tridge added this to Pending in Plane 4.3 Oct 15, 2022
@tridge tridge moved this from Pending to 4.3.1-beta1 in Plane 4.3 Oct 15, 2022
@tridge tridge merged commit 72c6977 into ArduPilot:master Oct 18, 2022
@rmackay9 rmackay9 added this to Pending in Copter 4.3 Oct 24, 2022
@rmackay9 rmackay9 moved this from Pending to 4.3.0-beta4 in Copter 4.3 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Copter 4.3
4.3.0 / 4.3.0-beta4
Plane 4.3
4.3.1-beta1
Development

Successfully merging this pull request may close these issues.

None yet

4 participants